Move System.Runtime.CompilerServices.CallConv* types to System.Private.CoreLib and expose via System.Runtime. #38473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modopt-based encoding down to System.Private.CoreLib/System.Runtime.
AaronRobinsonMSFT
approved these changes
Jun 26, 2020
...Runtime.CompilerServices.VisualC/src/System.Runtime.CompilerServices.VisualC.TypeForwards.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jun 26, 2020
...s/System.Runtime.CompilerServices.VisualC/src/System.Runtime.CompilerServices.VisualC.csproj
Outdated
Show resolved
Hide resolved
safern
approved these changes
Jun 26, 2020
… type forwards in the src assembly.
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
I have just noticed that the cc @333fred |
I think we'd prefer it to be in corelib, but I don't think we were going to require it. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the calling convention types used in the new calling convention modopt-based encoding down to System.Private.CoreLib/System.Runtime so they live in the same assembly as System.Object.
Fixes #38132