Remove MinHandles and OutstandingHandles logic from SocketAsyncEngine #36019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
added
the
NO-MERGE
|
Tagging subscribers to this area: @dotnet/ncl |
tmds
reviewed
May 7, 2020
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEngine.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 7, 2020
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEngine.Unix.cs
Show resolved
Hide resolved
adamsitnik
commented
May 8, 2020
|
|
||
| Debug.Assert(handle != ShutdownHandle, $"Expected handle != ShutdownHandle: {handle}"); |
There was a problem hiding this comment.
this is checked before adding to dictionary
adamsitnik
changed the title
adamsitnik
removed
the
NO-MERGE
|
I just confirmed that there are no regressions, the PR is ready for review |
tmds
approved these changes
May 8, 2020
|
Thanks for cleaning this up. |
stephentoub
reviewed
May 8, 2020
| { | ||
| s_currentEngines[s_allocateFromEngine] = engine = new SocketAsyncEngine(); | ||
| } | ||
| s_currentEngines[s_allocateFromEngine] = engine = new SocketAsyncEngine(); |
There was a problem hiding this comment.
FWIW, the above can be condensed to:
engine = s_currentEngines[s_allocateFromEngine] ??= new SocketAsyncEngine();There was a problem hiding this comment.
Nit: pre-existing your code, but the current in s_currentEngines seems superfluous. Maybe just s_engines.
stephentoub
approved these changes
May 8, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tmds here is the promised removal of MinHandles logic. I am going to run some benchmarks for it tomorrow.