Insert missing break in hwintrinsicarm64.cpp #35713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR to introduce / vectorise
Vector{Size}<T>.AllBitsSet / Zero
(#33924), there was a missing
break;
in a switch statement in the importation logic, which resulted in the correct functions not being imported asGT_HWINTRINSIC
nodes as the control fell through thedefault
block, returningnullptr
(meaning the method is not a valid HWINTRINSIC node and should be imported as regular function).This was pointed out in #35300 (comment) by @echesakovMSFT, where
Vector128.CreateScalar
methods were found out to be using the software fallback.JitDump of the importation part, prior to this change:
JitDump of the importation part, after this change:
(I'm so sorry for missing this out, I think the build I was testing with before was somehow outdated)