Fix host linker options to have -Bsymbolic #34534
Conversation
|
cc @mmitche The last command per the repro in dotnet/installer#7005 (comment) no longer crashes after patching the libhostpolicy that gets restored to the .dotnet folder |
| # This is required to map a symbol reference to a matching definition local to the module (.so) | ||
| # containing the reference instead of using definitions from other modules. | ||
| if(CLR_CMAKE_TARGET_LINUX) | ||
| set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Xlinker -Bsymbolic -Bsymbolic-functions") |
There was a problem hiding this comment.
I can see that we had it this way before, but the second option is effectively ignored. -Xlinker can be followed by only one linker option (in fact, if that linker option had a parameter, it would have to be prefixed by the -Xlinker too). So the -Bsymbolic-function actually sets a compiler option -B which adds symbolic-function to the libraries search path.
However, -Bsymbolic is stronger than -Bsymbolic-functions, so -BSymbolic alone is sufficient and there was no problem before. I'd suggest just removing the -Bsymbolic-functions here.
There was a problem hiding this comment.
Hah, wow. Yeah, definitely just copied the options from before. Removed -Bsymbolic-functions.
There was a problem hiding this comment.
Seems like we are using -Bsymbolic-functions in other places as well, can we extract it out in /eng/native/configurecompiler.cmake as a cleanup?
$ git grep Xlinker
src/coreclr/src/dlls/dbgshim/CMakeLists.txt: set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Xlinker -Bsymbolic -Xlinker -Bsymbolic-functions")
src/coreclr/src/dlls/mscordac/CMakeLists.txt: set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Xlinker -Bsymbolic -Xlinker -Bsymbolic-functions")
src/coreclr/src/dlls/mscordbi/CMakeLists.txt: set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Xlinker -Bsymbolic -Xlinker -Bsymbolic-functions")
src/coreclr/src/ilasm/CMakeLists.txt: set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Xlinker -Bsymbolic -Xlinker -Bsymbolic-functions")
src/coreclr/src/ildasm/exe/CMakeLists.txt: set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Xlinker -Bsymbolic -Xlinker -Bsymbolic-functions")
src/coreclr/src/jit/CMakeLists.txt: set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Xlinker -Bsymbolic -Bsymbolic-functions")
src/coreclr/src/pal/src/libunwind/aux_/ltmain.sh: -Xlinker)There was a problem hiding this comment.
Yeah, I noticed those (and them also having -Bsymbolic-function). I agree we should consolidate and clean them up. I wanted to keep this change small and targeted to just unblocking being able to insert into dotnet/installer.
There was a problem hiding this comment.
Let's get in this simple focused fix and do a cleanup for the -Bsymbolic-functions after.
@am11 I'd prefer keeping this option at the specific libraries and not make it global. I've seen several times in the past a case when someone has used a LD_PRELOAD with a helper library as a workround for a problem in a specific function in libcoreclr.so.
|
@janvorli @mmitche it looks like this will have to be ported to preview 3 to fix dotnet/installer#7005 |
|
OKay will do. |
* Fix host linker options to have -Bsymbolic * Remove -Bsymbolic-functions
* Fix host linker options to have -Bsymbolic * Remove -Bsymbolic-functions Co-authored-by: Elinor Fung <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Looks like this got lost after #33716
See dotnet/installer#7005