Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two issues detected by Valgrind #34462

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Fix two issues detected by Valgrind #34462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
206099c
Fix two issues detected by Valgrind
janvorli Apr 2, 2020
22832da
Move the dangerousObjRefs zeroing under _DEBUG ifdef
janvorli Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/coreclr/src/vm/threads.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1539,6 +1539,10 @@ Thread::Thread()
m_DeserializationTracker = NULL;

m_currentPrepareCodeConfig = nullptr;

#ifdef _DEBUG
memset(dangerousObjRefs, 0, sizeof(dangerousObjRefs));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be under debug ifdef?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it does. I have not noticed that it is a debug build only thing.

#endif // _DEBUG
}

//--------------------------------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/src/vm/win32threadpool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4119,6 +4119,8 @@ DWORD WINAPI ThreadpoolMgr::GateThreadStart(LPVOID lpArgs)
GetCPUBusyTime_NT(&prevCPUInfo);
#else // !TARGET_UNIX
PAL_IOCP_CPU_INFORMATION prevCPUInfo;
memset(&prevCPUInfo, 0, sizeof(prevCPUInfo));

GetCPUBusyTime_NT(&prevCPUInfo); // ignore return value the first time
#endif // !TARGET_UNIX

Expand Down