Fix build break in coreclr where -os is not supported in Windows #34358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
Apr 1, 2020
|
I was thinking since a special variable is declared runtime/src/coreclr/build-runtime.cmd Line 43 in 2ad6913 -os option? which seems to be rather missing from the script, if the intention of having separate variable was to support different values in future.
|
Do you see any value in the .cmd file? We can't cross target in windows, except for the linux and alpine dac, which have separate arguments, which is why the Let's unblock CI and we can keep the discussion about this. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows doesn't support -os argument since it is always Windows and in PR #34000, this two arguments were introduced with a failing build on Windows.