Speed up SuperPMI mcs -removeDup
#33939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a "Hash" class that encapsulates the MD5 hashing that is used to determine if two MCs are equivalent. Primarily, this allows caching the Windows Crypto provider, which it is very slow to acquire. In addition, make some changes to avoid unnecessary memory allocations and other unnecessary work. The result is that `mcs -removeDup` is about 4x faster. Much of the remaining cost is that we read, deserialize the MC, then reserialize the MC (if unique), and finally destroy the in-memory MC. There is a lot of memory allocation/deallocation in this process that could possibly be avoided or improved for this scenario.
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a "Hash" class that encapsulates the MD5 hashing that is
used to determine if two MCs are equivalent. Primarily, this
allows caching the Windows Crypto provider, which it is very slow
to acquire.
In addition, make some changes to avoid unnecessary memory allocations
and other unnecessary work.
The result is that
mcs -removeDupis about 4x faster.Much of the remaining cost is that we read, deserialize the MC,
then reserialize the MC (if unique), and finally destroy the in-memory MC.
There is a lot of memory allocation/deallocation in this process that
could possibly be avoided or improved for this scenario.