Fix GeneratorCommand in Microsoft.XmlSerializer.Generator.Tests.csproj #32446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On non-Windows operating systems we need to use `&&` to chain the two commands instead of a single ampersand.
|
Did that regress recently? |
ViktorHofer
approved these changes
Feb 17, 2020
|
It doesn't look like it regressed, it's the same as when you added it 8 months ago: d40f54d |
|
So the environment variables was never working as expected as it was invoked in parallel and not sharing state. @akoeplinger how did you catch this? just interested |
|
Failures is #32300. @akoeplinger please don't merge a PR with a failing leg without linking to its issue / creating one, according to the PR guide. |
|
I caught it in my WIP branch which adds iOS build configurations. I think I was manually running some projects so it's possible this ran sequentially for me. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-Windows operating systems we need to use
&&to chain the two commands instead of a single ampersand.