-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CLR_CMAKE_HOST_ARCH CLR_CMAKE_PLATFORM_ARCH #1887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the term host for being more explicit. However, I am not married to this. @jkoritzinsky and @janvorli would have more context between the terms
I think platform works better than host if we ever were to cross-build something that works with another arch (for example, a Linux x86 crossgen that outputs Linux ARM32 native code built on a Linux x64 machine). In this scenario, these would be the definitions of the terms:
In most if not all of our cases today, Host == Platform. |
Good point. Fair then.
I guess only ARM/ARM64 cross compiles? |
x86 (once / if we start to build it) would cross-compile too. We have support for it in our rootfs building scripts and our customers are using it. |
5aefc44
to
7311f4c
Compare
We should stick to the definitions of terms that everybody else is using, so that people do not have to have a special decoder ring for our system: https://clang.llvm.org/docs/CrossCompilation.html Host: The os/build arch that the built code runs on |
Notice that nobody uses "platform" to name any of these 3. If "platform" is used, it is always with combination with other qualifier, e.g. "host platform" or "target platform". |
I’m good with matching clang and GCC. |
I'll close this and write the opposite patch... It'll be bigger... |
We were currently using both the term "Platform" and "Host" to refer to the architecture of the executing code. They both are distiguished from the "Target" which is the architecture of the debug target, or JIT target.
The term "Platform" is dominant in the code. This changes the HOST usages to PLATFORM before adding more complexity for cross OS compilation.