Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] ILStrip write directly to the output filestream #112142

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

lewing
Copy link
Member

@lewing lewing commented Feb 4, 2025

No description provided.

@lewing lewing force-pushed the dispose-memorystream branch from 47b7aa6 to 1b49249 Compare February 4, 2025 19:12
@lewing lewing closed this Feb 4, 2025
@lewing lewing reopened this Feb 4, 2025
@lewing lewing requested a review from steveisok February 4, 2025 19:33
@lewing lewing changed the title [mono] IL Strip make sure the MemoryStream is disposed [mono] ILStrip write directly to the output filestream Feb 5, 2025
src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated Show resolved Hide resolved
src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated Show resolved Hide resolved
src/tasks/MonoTargetsTasks/ILStrip/ILStrip.cs Outdated Show resolved Hide resolved
@lewing lewing merged commit 99d48c2 into dotnet:main Feb 5, 2025
138 of 141 checks passed
@lewing lewing deleted the dispose-memorystream branch February 5, 2025 20:39
grendello added a commit to grendello/runtime that referenced this pull request Feb 6, 2025
* main: (23 commits)
  add important remarks to NrbfDecoder (dotnet#111286)
  docs: fix spelling grammar and missing words in clr-code-guide.md (dotnet#112222)
  Consider type declaration order in MethodImpls (dotnet#111998)
  Add a feature flag to not use GVM in Linq Select (dotnet#109978)
  [cDAC] Implement ISOSDacInterface::GetMethodDescPtrFromIp (dotnet#110755)
  Restructure JSImport/JSExport generators to share more code and utilize more Microsoft.Interop.SourceGeneration shared code (dotnet#107769)
  Add more detailed explanations to control-flow RegexOpcode values (dotnet#112170)
  Add repo-specific condition to labeling workflows (dotnet#112169)
  Fix bad assembly when a nested exported type is marked via link.xml (dotnet#107945)
  Make `CalculateAssemblyAction` virtual. (dotnet#112154)
  JIT: Enable reusing profile-aware DFS trees between phases (dotnet#112198)
  Add support for LDAPTLS_CACERTDIR \ TrustedCertificateDirectory (dotnet#111877)
  JIT: Support custom `ClassLayout` instances with GC pointers in them (dotnet#112064)
  Factor positive lookaheads better into find optimizations (dotnet#112107)
  Add ImmutableCollectionsMarshal.AsMemory (dotnet#112177)
  [mono] ILStrip write directly to the output filestream (dotnet#112142)
  Allow the NativeAOT runtime pack to be specified as the ILC runtime package (dotnet#111876)
  JIT: some reworking for conditional escape analysis (dotnet#112194)
  Replace HELPER_METHOD_FRAME with DynamicHelperFrame in patchpoints (dotnet#112025)
  [Android] Decouple runtime initialization and entry point execution for Android sample (dotnet#111742)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants