-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to prevent merging a PR when the NO-MERGE
label is applied
#111940
Conversation
steps: | ||
- name: Check 'NO-MERGE' label | ||
run: | | ||
echo "Merging permission is disabled when the `NO-MERGE` label is applied." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this is backwards. When the label is applied, we need to go to the error. When it is not applied, we exit 0.
Will fix tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that the backticks in the echo string mean that bash will try to run that as a command. this is a bug in the servicing-labels action too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, didn't know that. Thanks for noticing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means we have a bug here! I'll include the fix in this PR:
echo "Merging permission is enabled for servicing PRs when the `Servicing-approved` label is applied." |
cc @hoyosjs fyi
/backport to release/9.0-staging |
/backport to release/8.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13036681388 |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/13036684248 |
Fixes #105452
We should backport to the servicing branches as well.