Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs on building ILVerify #111851

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Improve docs on building ILVerify #111851

merged 7 commits into from
Jan 28, 2025

Conversation

kant2002
Copy link
Contributor

  • Much faster to build now, less deps
  • Fix names of the projects
  • Fix instruction for running tests based on latest changes in the test infra, have funny error on Windows when use Linux style slashes. Would like to fix this in CoreRun if possible.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 27, 2025
jkotas
jkotas reviewed Jan 27, 2025
View reviewed changes
src/coreclr/tools/ILVerify/README.md Outdated
As the test project is marked with priority=1, simply building the test projects from the root of the project is not enough. For the initial build of priority=1 in release mode, run the following:

```sh
src/tests/build.(cmd/sh) release -priority=1
```

or significantly faster use only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing instructions can be deleted. I guess they were written before the test build had tree option.

jkotas
jkotas reviewed Jan 27, 2025
View reviewed changes
src/coreclr/tools/ILVerify/README.md Outdated
@@ -48,24 +48,39 @@ The test project itself is under [src/tests/ilverify](../../../tests/ilverify)

General instructions to build this library can be found [here](https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/coreclr/testing.md).

As quick snippet which should be enough to build CoreCLR
```
./build.cmd -s clr.native+clr.corelib+clr.tools+clr.nativecorelib+libs -c release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this significantly better than just -s clr+libs?

kant2002
kant2002 commented Jan 27, 2025
View reviewed changes
Copy link
Contributor Author

@kant2002 kant2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply PR suggestions

@jkotas jkotas merged commit 22be4ca into dotnet:main Jan 28, 2025
16 checks passed
grendello added a commit to grendello/runtime that referenced this pull request Jan 28, 2025
@grendello
Merge branch 'main' into dev/grendel/android-clr-host-local
74220ed 
* main: (31 commits)
  Fix linux-x86 build (dotnet#111861)
  Add FrozenDictionary specialization for integers / enums (dotnet#111886)
  [SRM] Refactor reading from streams. (dotnet#111323)
  Sign the DAC and DBI during the build process instead of in separate steps (dotnet#111416)
  Removing Entry2MethodDesc as it is unnecessary (dotnet#111756)
  Cross Product for Vector2 and Vector4 (dotnet#111265)
  Handle unicode in absolute URI path for combine. (dotnet#111710)
  Drop RequiresProcessIsolation on mcc tests (dotnet#111887)
  [main] Update dependencies from dotnet/roslyn (dotnet#111691)
  new trimmer feature System.TimeZoneInfo.Invariant (dotnet#111215)
  [browser] reduce msbuild memory footprint (dotnet#111751)
  Add debugging checks for stack overflow tests failure (dotnet#111867)
  Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2629821 (dotnet#111884)
  Bump main to preview2 (dotnet#111882)
  Avoid generic virtual dispatch for frozen collections alternate lookup (dotnet#108732)
  Bump main versioning to preview1 (dotnet#111880)
  Switch OneLoc to main (dotnet#111872)
  Improve docs on building ILVerify (dotnet#111851)
  Update Debian version to 13 (dotnet#111768)
  win32: add fallback to environment vars for system folder (dotnet#109673)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-ILVerification community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kant2002 @jkotas