System.Text.Json: Fix polymorphic state bug when using ReferenceHandler.IgnoreCycles #111808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear the polymorphic state after ignoring a reference to prevent subsequent object writes from inheriting it.
dotnet-policy-service
bot
added
the
community-contribution
|
|
||
| worker1.Office.Staff = [worker1]; | ||
|
|
||
| await Test_Serialize_And_SerializeAsync(worker1, """{"Office":{"Staff":[null],"Dummy":{}}}""", s_optionsIgnoreCycles); |
There was a problem hiding this comment.
This looks good. Could you also include a test for the same type using ReferenceHandler.Preserve?
There was a problem hiding this comment.
IgnoreCycles and Preserve tests are a bit separated, so I just copied the classes over. I could otherwise just add another two lines in this test if youd like that better.
|
[experimenting with copilot reviews] |
This was referenced Jan 28, 2025
Open
3 tasks
|
@danmoseley Seems it never provided a review? |
|
Judging by the test failures this type |
|
Thanks for your patience. Seems like the remaining test failures are unrelated. |
|
Thank you for your contribution @yesmey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear the polymorphic state after ignoring a reference in an array to prevent subsequent objects from inheriting it.
Add a test which triggered an assertion in
runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverter.MetadataHandling.cs
Line 74 in 03b2d3d
and covers the scenario reported in #111790
Fixes #111790