R2RDump: Fix reversed code offsets in GcInfo interruptible ranges decoder #111792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-R2RDump-coreclr
dotnet-policy-service
bot
added
the
community-contribution
tomeksowi
changed the title
VSadov
reviewed
Jan 24, 2025
| @@ -381,8 +381,8 @@ private List<InterruptibleRange> EnumerateInterruptibleRanges(byte[] image, int | |||
| uint normRangeStartOffset = normLastinterruptibleRangeStopOffset + normStartDelta; | |||
| uint normRangeStopOffset = normRangeStartOffset + normStopDelta; | |||
|
|
|||
| uint rangeStartOffset = _gcInfoTypes.DenormalizeCodeOffset(normRangeStopOffset); | |||
| uint rangeStopOffset = _gcInfoTypes.DenormalizeCodeOffset(normRangeStartOffset); | |||
| uint rangeStartOffset = _gcInfoTypes.DenormalizeCodeOffset(normRangeStartOffset); | |||
There was a problem hiding this comment.
Looks like it was swapped in #110845. Possibly a copy/paste error.
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
VSadov
approved these changes
Jan 24, 2025
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Jan 27, 2025
* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused a crash on RISC-V during R2RDump --in System.Private.CoreLib.dll --disasm --gc
Part of #84834, cc @dotnet/samsung @VSadov