Update host test RID fallbacks to include arm64 #109235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
AaronRobinsonMSFT
approved these changes
Oct 25, 2024
jkoritzinsky
approved these changes
Oct 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running against a mock coreclr, host tests create a minimal Microsoft.NETCore.App.deps.json that also includes a sparse fallback RID graph. That graph gets used in tests for RID-specific asset resolution that target explicitly enabling the RID fallback graph. This change adds arm64 to the mock RID fallback graph, which should allow those tests to run properly on arm64.
Contributes to #77800
cc @dotnet/appmodel @AaronRobinsonMSFT