Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle top-level UseSystemLibs argument from the VMR #104440

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

omajid
Copy link
Member

@omajid omajid commented Jul 4, 2024

This will be used by dotnet/sdk#41984

It's another attempt at #101797

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 4, 2024
omajid added a commit to omajid/dotnet-sdk that referenced this pull request Jul 4, 2024
Some environments, at least some Linux distributions, want to use system
versions of certain libraries rather than the source code copy shipped
with the .NET runtime source repository. We can provide a top-level flag
to support this scenario that can be used like this:

    ./build.sh -p:UseSystemLibs=brotli+libunwind+rapidjson+zlib

Which makes the VMR build the runtime repo such that it uses the system
version of brotli, libunwind, rapidjson and zlib.

This is another attempt at
dotnet/installer#19640

It depends on dotnet/runtime#104440 to work.
@jkotas jkotas added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 8, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

akoeplinger pushed a commit to dotnet/sdk that referenced this pull request Jul 8, 2024
Some environments, at least some Linux distributions, want to use system versions of certain libraries rather than the source code copy shipped with the .NET runtime source repository. We can provide a top-level flag to support this scenario that can be used like this:

    ./build.sh -p:UseSystemLibs=brotli+libunwind+rapidjson+zlib

Which makes the VMR build the runtime repo such that it uses the system version of brotli, libunwind, rapidjson and zlib.

This is another attempt at dotnet/installer#19640

It depends on dotnet/runtime#104440 to work.
@akoeplinger akoeplinger merged commit dbe63a7 into dotnet:main Jul 8, 2024
140 of 148 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants