Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EnC] Implement the UpdateParameters capability #56626

Closed
Tracked by #57365
lambdageek opened this issue Jul 30, 2021 · 0 comments · Fixed by #85796
Closed
Tracked by #57365

[EnC] Implement the UpdateParameters capability #56626

lambdageek opened this issue Jul 30, 2021 · 0 comments · Fixed by #85796
Assignees
@fanyang-mono
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Milestone
8.0.0

Comments

@lambdageek
Copy link
Member

See dotnet/roslyn#52563 (and dotnet/roslyn#54856). CoreCLR has this in .net6 as it's in line with what they can already support (but the capability itself is added in #56599).

For Mono the main place where we will be affected is in the debugger agent - we will need to make sure to send the updated parameter names to the debugger client. (Also reflection will be affected).

Additionally parameter flags, not just parameter names, can change - but those seem more benign because for the most part they're related to compile-time concepts not runtime.

This is part of #44806 (but not the .net6 work for MBR)
@lambdageek lambdageek added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label Jul 30, 2021
@lambdageek lambdageek added this to the 7.0.0 milestone Jul 30, 2021
@lambdageek lambdageek mentioned this issue Jul 30, 2021
Closed
51 tasks
@karelz karelz added the untriaged New issue has not been triaged by the area owner label Jul 31, 2021
@lambdageek lambdageek removed the untriaged New issue has not been triaged by the area owner label Aug 2, 2021
@lambdageek lambdageek mentioned this issue Aug 13, 2021
Closed
27 tasks
@marek-safar marek-safar modified the milestones: 7.0.0, 8.0.0 Aug 7, 2022
@marek-safar marek-safar changed the title [EnC] Mono should implement the UpdateParameters capability [EnC] Implement the UpdateParameters capability Apr 19, 2023
@lambdageek lambdageek mentioned this issue Apr 26, 2023
Merged
@fanyang-mono fanyang-mono mentioned this issue May 4, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 4, 2023
lambdageek added a commit that referenced this issue Jun 16, 2023
@fanyang-mono @lambdageek
[Mono] Add mono hot reload support for updating parameter name (#85796)
cc7448c 
Fixes #56626
Fixes #50978

* Add mono hot reload support for updating parameter name

* Add a debugger test

* Don't invalidate the whole assembly when using hot reload

* don't ignore reflection cache entries when the "no invalidate" flag is set

---------

Co-authored-by: Aleksey Kliger <[email protected]>
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fanyang-mono fanyang-mono

Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[Mono] Add mono hot reload support for updating parameter name fanyang-mono/runtime
4 participants
@marek-safar @lambdageek @karelz @fanyang-mono