Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS][globalization] Missing support for ICU #50912

Closed
spouliot opened this issue Apr 8, 2021 · 4 comments
Closed

[tvOS][globalization] Missing support for ICU #50912

spouliot opened this issue Apr 8, 2021 · 4 comments
Assignees
Milestone

Comments

@spouliot
Copy link
Contributor

spouliot commented Apr 8, 2021

Description

#49406 added ICU support for iOS (in P3). However similar support for tvOS was not added and runs into the same issue (stuck with invariant).

Note: it's unclear is Catalyst apps will be allowed (for App Store) to use the system ICU like it's being done for macOS. If Catalyst apps goes thru the same review process as iOS apps then ICU support will also be needed.

Configuration

  • SDK 6.0.100-preview.3.21202.5

Regression?

Yes. Legacy Xamarin.tvOS SDK supports globalization.

Other information

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Globalization untriaged New issue has not been triaged by the area owner labels Apr 8, 2021
@ghost
Copy link

ghost commented Apr 8, 2021

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

#49406 added ICU support for iOS (in P3). However similar support for tvOS was not added and runs into the same issue (stuck with invariant).

Note: it's unclear is Catalyst apps will be allowed (for App Store) to use the system ICU like it's being done for macOS. If Catalyst apps goes thru the same review process as iOS apps then ICU support will also be needed.

Configuration

  • SDK 6.0.100-preview.3.21202.5

Regression?

Yes. Legacy Xamarin.tvOS SDK supports globalization.

Other information

Author: spouliot
Assignees: -
Labels:

area-System.Globalization, untriaged

Milestone: -

@spouliot
Copy link
Contributor Author

spouliot commented Apr 8, 2021

c.c. @steveisok

@tarekgh tarekgh added the os-tvos Apple tvOS label Apr 8, 2021
@tarekgh tarekgh added this to the 6.0.0 milestone Apr 8, 2021
@tarekgh tarekgh removed the untriaged New issue has not been triaged by the area owner label Apr 8, 2021
spouliot added a commit to spouliot/xamarin-macios that referenced this issue Apr 8, 2021
and re-enable some tests for dotnet

Part of the fix for dotnet#8906

Known Issues
* [some Calendar are not the expected ones](dotnet/runtime#50859)
* [No support for tvOS](dotnet/runtime#50912)
@steveisok
Copy link
Member

I validated the icu bits are in the tvOS runtime pack feed. What errors are you seeing?

@spouliot
Copy link
Contributor Author

spouliot commented Apr 8, 2021

The FailFast / missing ICU error happens because of

if TARGET_OS_TV
	rv = 0;
	// Due to https://github.com/dotnet/runtime/issues/48508, we can't link with the .NET version of libmonosgen-2.0.dylib,
	// which means that we can't call monovm_initialize here (libxamarin.dylib fails native linking). Just ignore it for now.
	fprintf (stderr, "xamarin_vm_initialize (%i, %p, %p): Ignored due to https://github.com/dotnet/runtime/issues/48508.\n", propertyCount, propertyKeys, propertyValues);
#else

@spouliot spouliot closed this as completed Apr 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants