Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dictionary sometimes uses Ordinal hash code calculation instead of OrdinalIgnoreCase #44695

Closed
GrabYourPitchforks opened this issue Nov 15, 2020 · 1 comment
Closed

Dictionary sometimes uses Ordinal hash code calculation instead of OrdinalIgnoreCase #44695

GrabYourPitchforks opened this issue Nov 15, 2020 · 1 comment
Labels
area-System.Runtime bug regression-from-last-release
Milestone
6.0.0

Comments

@GrabYourPitchforks
Copy link
Member

See comment at #44681 (comment). When too many collisions are seen in a Dictionary<string, ...>(StringComparer.OrdinalIgnoreCase) or HashSet<string>(StringComparer.OrdinalIgnoreCase), we'll accidentally fall back to StringComparer.Ordinal after re-bucketing entries.

This is a regression from netcoreapp3.1 and should be serviced for net 5.0.x.
@GrabYourPitchforks GrabYourPitchforks added this to the 6.0.0 milestone Nov 15, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 15, 2020
@GrabYourPitchforks GrabYourPitchforks removed the untriaged New issue has not been triaged by the area owner label Nov 15, 2020
@GrabYourPitchforks GrabYourPitchforks mentioned this issue Nov 15, 2020
Merged
@GrabYourPitchforks GrabYourPitchforks mentioned this issue Nov 22, 2020
Merged
@GrabYourPitchforks
Copy link
Member Author

PR into 6.0 master: #44688
PR into 5.0.x servicing: #45062

GrabYourPitchforks pushed a commit that referenced this issue Nov 24, 2020
@github-actions
[release/5.0] Handle non-ASCII strings in GetNonRandomizedHashCodeOrd…
d9a4a64 
…inalIgnoreCase (#45062)

* Backports #44681 fix to 5.0
* Backports #44695 fix to 5.0
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime bug regression-from-last-release
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@GrabYourPitchforks @Dotnet-GitSync-Bot