-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider offering a way to disable libmsquic
testing
#110556
Comments
Tagging subscribers to this area: @dotnet/ncl |
from what I know, if we can't detect |
I see, thanks I totally forgot about these. It makes sense to me adding something like this in that case. |
Should I remove |
With whatever we do, we should bias to least effort. This is not a request for "perfect". |
We do have mechanism to disable tests on given platform and we used it in the past. It is not great but it is sufficient IMHO if that is very rare case. If anything, I feel we should streamline msquic support for new distributions. Involve them immediate when we know instead of fining it last when we try to build new docker image and suck it into testing. Note that Alpine now has libmsquic as part of OS so moving to new versions should not be problem IMHO. Ideally, I feel we can encourage more vendors to go that route and for example work with Canonical. if we want to make it cheaper, I can live with ENV variable as long as we open tracking issue to remove it. We had problems in the past were support for give OS was just silently missed. @ManickaP is out for rest of the year so this will probably need to wait for some time. |
Few thoughts on those 2 issues from #110556 (comment):
I think the ENV var is not necessary here. In both cases, we have an existing, functioning process how to handle these scenarios - file an issue, do not attempt to make it work, we'll take care of it. Lastly, I wanted to say that I'm sorry this is causing you unnecessary pain and I fell you. Feel free to ping me personally or our team next time before you start the endeavor of adding new distro. I or someone from my team can assist you. Unfortunately, this is a specific circumstance where we don't have 100% control over the whole thing and I don't think there's much better way to handle it. |
Sounds good. I can give that a try. Thanks for your help. |
I have seen several cases where our tests runs ahead of
libmsquic
availability. When that happens, we either wait or build the code from source. When we build from source, we pin to a specific version. I don't think either of those cases are desirable.I think it would much better if we could set an ENV in our container images that had the effect of disabling any tests that relied on
libmsquic
. Once the MSQuic supported for that OS, we could then install the packages in the image (and remove the ENV).I'm looking for ways to making managing our infra cheaper. This change would help significantly. I believe that
libmsquic
is a unique component, not coming from the distro or our team, but somewhere else (at least for our test images).Related:
libmsquic
support for Ubuntu 24.10 dotnet-buildtools-prereqs-docker#1286@wfurt
The text was updated successfully, but these errors were encountered: