Fixing behavior for iSimdVector helper

dotnet · Mar 21, 2024 · d8bc357 · d8bc357
1 parent 0772e00
commit d8bc357
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 9 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.cs b/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.cs
@@ -694,8 +694,7 @@ private string ToString([StringSyntax(StringSyntaxAttribute.NumericFormat)] stri
 
         static bool ISimdVector<Vector128<T>, T>.AnyMatches(Vector128<T> vector)
         {
-            uint mask = vector.ExtractMostSignificantBits();
-            return (mask != 0);
+            return (vector != Vector128<T>.Zero);
         }
 
         static int ISimdVector<Vector128<T>, T>.IndexOfLastMatch(Vector128<T> vector)

diff --git a/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.cs b/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.cs
@@ -684,8 +684,7 @@ private string ToString([StringSyntax(StringSyntaxAttribute.NumericFormat)] stri
 
         static bool ISimdVector<Vector256<T>, T>.AnyMatches(Vector256<T> vector)
         {
-            uint mask = vector.ExtractMostSignificantBits();
-            return (mask != 0);
+            return (vector != Vector256<T>.Zero);
         }
 
         static int ISimdVector<Vector256<T>, T>.IndexOfLastMatch(Vector256<T> vector)

diff --git a/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.cs b/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.cs
@@ -684,8 +684,7 @@ private string ToString([StringSyntax(StringSyntaxAttribute.NumericFormat)] stri
 
         static bool ISimdVector<Vector512<T>, T>.AnyMatches(Vector512<T> vector)
         {
-            ulong mask = vector.ExtractMostSignificantBits();
-            return (mask != 0);
+            return (vector != Vector512<T>.Zero);
         }
 
         static int ISimdVector<Vector512<T>, T>.IndexOfLastMatch(Vector512<T> vector)

diff --git a/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.cs b/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.cs
@@ -759,8 +759,7 @@ private string ToString([StringSyntax(StringSyntaxAttribute.NumericFormat)] stri
 
         static bool ISimdVector<Vector64<T>, T>.AnyMatches(Vector64<T> vector)
         {
-            uint mask = vector.ExtractMostSignificantBits();
-            return (mask != 0);
+            return (vector != Vector64<T>.Zero);
         }
 
         static int ISimdVector<Vector64<T>, T>.IndexOfLastMatch(Vector64<T> vector)

diff --git a/src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs b/src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs
@@ -2204,7 +2204,7 @@ private static unsafe bool HasMatch<TVectorByte>(TVectorByte vector)
             {
                 return VectorContainsNonAsciiChar((Vector128<byte>)(object)vector);
             }
-            return TVectorByte.AnyMatches(vector);
+            return ((vector & TVectorByte.Create((byte)0b1000_0000)) != TVectorByte.Zero);
         }
-Original file line number
+Diff line change
@@ Expand Up @@
                 {
                     return VectorContainsNonAsciiChar((Vector128<byte>)(object)vector);
                 }
-                return TVectorByte.AnyMatches(vector);
+                return ((vector & TVectorByte.Create((byte)0b1000_0000)) != TVectorByte.Zero);
             }
@@ Expand Down @@