Address PR feedback

dotnet · Apr 9, 2021 · 693c22b · 693c22b
1 parent 7436bbb
commit 693c22b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/libraries/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.Shared.xml b/src/libraries/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.Shared.xml
@@ -29,6 +29,11 @@
     <type fullname="System.Diagnostics.DebuggerVisualizerAttribute">
       <attribute internal="RemoveAttributeInstances" />
     </type>
+
+    <!-- Hot reload attributes-->
+    <type fullname="System.Reflection.Metadata.MetadataUpdateHandlerAttribute">
+      <attribute internal="RemoveAttributeInstances" />
+    </type>
   </assembly>
 
   <assembly fullname="System.Private.CoreLib" feature="System.Diagnostics.Tracing.EventSource.IsSupported" featurevalue="false">

diff --git a/...s/System.Private.CoreLib/src/System/Reflection/Metadata/MetadataUpdateHandlerAttribute.cs b/...s/System.Private.CoreLib/src/System/Reflection/Metadata/MetadataUpdateHandlerAttribute.cs
@@ -15,6 +15,7 @@ public MetadataUpdateHandlerAttribute([DynamicallyAccessedMembers(DynamicallyAcc
             HandlerType = handlerType;
 
         /// <summary>Gets the type that handles metadata updates and that should be notified when any occur.</summary>
+        [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)]
         public Type HandlerType { get; }
     }
 }
diff --git a/src/libraries/System.Runtime/tests/System/Reflection/ReflectionCacheTests.cs b/src/libraries/System.Runtime/tests/System/Reflection/ReflectionCacheTests.cs
@@ -5,7 +5,6 @@
 
 namespace System.Reflection.Tests
 {
-    [SkipOnMono("Mono doesn't have a reflection cache")]
     public class ReflectionCacheTests
     {
         [Fact]
@@ -20,6 +19,7 @@ public void GetMethod_MultipleCalls_SameObjects()
             Assert.Same(mi1, mi2);
         }
 
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/50978", TestRuntimes.Mono)]
         [Fact]
         public void GetMethod_MultipleCalls_ClearCache_DifferentObjects()
         {