Support custom path of a test file #1609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norritt
reviewed
Jan 20, 2025
|
|
||
| Document additionalDocument = project.AddDocument( | ||
| documentName, | ||
| SourceText.From(additionalFiles[i].Source), | ||
| filePath: Path.Combine(directoryPath, documentName)); | ||
| filePath: Path.Combine(directoryPath, additionalFiles[i].Path ?? documentName)); |
There was a problem hiding this comment.
I'd suggest
Suggested change
| filePath: Path.Combine(directoryPath, additionalFiles[i].Path ?? documentName)); | |
| filePath: Path.Combine(directoryPath, Path.GetDirectoryName(additionalFiles[i].Path ?? documentName), documentName)); |
that should properly process passed paths without file name, like Foo/Bar/ or something like this
There was a problem hiding this comment.
I added validation of file path
| @@ -362,12 +362,12 @@ internal static (Document document, ImmutableArray<ExpectedDocument> expectedDoc | |||
|
|
|||
| for (int i = 0; i < additionalFiles.Length; i++) | |||
| { | |||
| string documentName = AppendNumberToFileName(options.DocumentName, i + 2); | |||
| string documentName = Path.GetFileName(additionalFiles[i].Path) ?? AppendNumberToFileName(options.DocumentName, i + 2); | |||
There was a problem hiding this comment.
in case I am providing only a path, it could work erroneously. I do not know how it would behave for cases Foo/Bar and Foo/Bar/
There was a problem hiding this comment.
I added validation of file path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.