Fix analyzer RCS1264 (#1511)

dotnet · Sep 1, 2024 · f945094 · f945094
1 parent 6a85d83
commit f945094
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fix analyzer [RCS1198](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1198) ([PR](https://github.com/dotnet/roslynator/pull/1501))
 - Fix analyzer [RCS1214](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1214) ([PR](https://github.com/dotnet/roslynator/pull/1500))
 - Fix analyzer [RCS1018](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1018) ([PR](https://github.com/dotnet/roslynator/pull/1510))
+- Fix analyzer [RCS1264](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1264) ([PR](https://github.com/dotnet/roslynator/pull/1511))
 
 ## [4.12.4] - 2024-06-01
 

diff --git a/src/CSharp/CSharp/CSharpTypeAnalysis.cs b/src/CSharp/CSharp/CSharpTypeAnalysis.cs
@@ -271,9 +271,6 @@ public static bool IsTypeObvious(ExpressionSyntax expression, ITypeSymbol? typeS
             case SyntaxKind.TrueLiteralExpression:
             case SyntaxKind.FalseLiteralExpression:
             case SyntaxKind.ThisExpression:
-                {
-                    return true;
-                }
             case SyntaxKind.ObjectCreationExpression:
             case SyntaxKind.ArrayCreationExpression:
             case SyntaxKind.CastExpression:

diff --git a/src/Tests/Analyzers.Tests/RCS1264UseVarOrExplicitTypeTests3.cs b/src/Tests/Analyzers.Tests/RCS1264UseVarOrExplicitTypeTests3.cs
@@ -353,6 +353,22 @@ void M()
         int x = I.Parse("");
     }
 }
+""", options: Options.AddConfigOption(ConfigOptionKeys.UseVar, ConfigOptionValues.UseVar_WhenTypeIsObvious));
+    }
+
+    [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseVarOrExplicitType)]
+    public async Task TestNoDiagnostic_SpanWithStringLiteral()
+    {
+        await VerifyNoDiagnosticAsync("""
+using System;
+
+class C
+{
+    void M()
+    {
+        ReadOnlySpan<char> span = "";
+    }
+}
 """, options: Options.AddConfigOption(ConfigOptionKeys.UseVar, ConfigOptionValues.UseVar_WhenTypeIsObvious));
     }
 }