Always specify Image width/height for glyphs sourced from IGlyphService #76935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In VS 17.13, the editor's `IGlyphService` implementation was improved to return images from `IVsImageService2` based on the appropriate moniker. This fixes several instances of blurry 16px icons throughout the IDE. Unfortunately, some WPF components failed to specify explicit `Image` dimensions, leading to larger than expected glyphs in the UI. Additionally, these proper VS icons require theming, or else you can get black-on-black or other poor contrast scenarios. These changes add explicit dimensions to `Image`s that display glyphs from `IGlyphService`. It also uses `ThemedImageSourceConverter` to theme the images correctly. Sometimes this requires setting `ImageThemingUtilities.ImageBackgroundColor`. NOTE: `MoveStaticMembersDialog` is not themed, so I did not apply the changes necessary to theme the icon correctly.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
JoeRobich
approved these changes
Jan 27, 2025
|
Resolves #76772 |
BTW, here's 17.12...
After this PR
|
|
I kinda like the current state. It has... gravitas. |
CyrusNajmabadi
approved these changes
Jan 27, 2025
That is a crisp image! |
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VS 17.14 (and previews of 17.13, but we are reverting for P5), the editor's
IGlyphServiceimplementation was improved to return images fromIVsImageService2based on the appropriate moniker. This fixes several instances of blurry 16px icons throughout the IDE.Unfortunately, some WPF components failed to specify explicit
Imagedimensions, leading to larger than expected glyphs in the UI.Additionally, these proper VS icons require theming, or else you can get black-on-black or other poor contrast scenarios.
These changes add explicit dimensions to
Images that display glyphs fromIGlyphService. It also usesThemedImageSourceConverterto theme the images correctly. Sometimes this requires settingImageThemingUtilities.ImageBackgroundColor.NOTE:
MoveStaticMembersDialogis not themed, so I did not apply the changes necessary to theme the icon correctly.