Move internal tools restore out of CI yaml and into eng/build.ps1 #76911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal tools must be restored before loading the powershell module to find IBCM merge data. To work nicely with VMR builds, which call roslyn's eng/build.ps1 script, move this restore logic out of the YAML and into the eng/build.ps1 script. The tools are only restored when we know we need to load the module. Note that the tools project will already be restored again automatically when roslyn builds because of the use of IBC data.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
Needs internal build and VMR verification. |
|
It looks like Arcade's use of the devdiv.visualstudio.com URI in the restore sources in the project doesn't work, because the service connections auth to the dev.azure.com/devdiv versions. This will need to be resolved before this can go in. |
dibarbet
approved these changes
Jan 27, 2025
|
@dibarbet Updated to a newer arcade that has a fix for the previous issue, and fixed up coherency in the repo (xliff tasks moved into Arcade). |
dibarbet
added a commit
that referenced
this pull request
Jan 31, 2025
#76984) restore internal tools was moved out of yaml in official build, also needs to happen with PR val build See #76911 pr val build (just needs to get past build step) - https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10928060&view=logs&j=d8f66498-7756-5707-3b43-f2312930a35f&t=bf681905-b801-52f4-803f-be09a0d10104
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal tools must be restored before loading the powershell module to find IBCM merge data. To work nicely with VMR builds, which call roslyn's eng/build.ps1 script, move this restore logic out of the YAML and into the eng/build.ps1 script. The tools are only restored when we know we need to load the module. Note that the tools project will already be restored again automatically when roslyn builds because of the use of IBC data.