Add support for converting an auto-prop to a field-backed property. #76900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jan 24, 2025
| @@ -41,23 +42,9 @@ protected override bool SupportsReadOnlyProperties(Compilation compilation) | |||
| protected override bool SupportsPropertyInitializer(Compilation compilation) | |||
| => compilation.LanguageVersion() >= LanguageVersion.CSharp6; | |||
|
|
|||
| protected override bool SupportsFieldExpression(Compilation compilation) | |||
| => compilation.LanguageVersion() >= LanguageVersion.Preview; | |||
There was a problem hiding this comment.
moved to SyntaxFacts, where we have our other checks.
CyrusNajmabadi
commented
Jan 24, 2025
| @@ -18,7 +19,7 @@ namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.UseImplicitlyTypedLambd | |||
| [Trait(Traits.Feature, Traits.Features.CodeActionsUseImplicitObjectCreation)] | |||
| public sealed class UseImplicitlyTypedLambdaExpressionTests | |||
| { | |||
| private static readonly LanguageVersion CSharp14 = LanguageVersion.Preview; | |||
| private static readonly LanguageVersion CSharp14 = LanguageVersionExtensions.CSharpNext; | |||
There was a problem hiding this comment.
we use CSharpNext as there's a process where we look for this when adding the actual CSharp14 LangVersion before shpping that release.
CyrusNajmabadi
commented
Jan 24, 2025
| CSharpCodeGenerationContextInfo info, | ||
| PropertyDeclarationSyntax property, | ||
| ExpressionSyntax backingFieldExpression, | ||
| CancellationToken cancellationToken) | ||
| { |
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Jan 24, 2025
| M(field); | ||
| field = value; | ||
| M(p); | ||
| p = value; |
There was a problem hiding this comment.
this was a bug fix. when converting these to a full property, 'field' should be replaced with the final field name.
CyrusNajmabadi
changed the title
JoeRobich
approved these changes
Jan 24, 2025
This was referenced Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76899
Fixes #76901
Looks like: