Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt in MS.CA.LS.Protocol into using optprof training data #76768

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Opt in MS.CA.LS.Protocol into using optprof training data #76768

merged 1 commit into from
Jan 23, 2025

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Jan 15, 2025 •
edited
Loading

Verified this produces a dll with data embedded

PS C:\Users\dabarbet\Downloads\net472> .\ibcmerge.exe -dxml -mi C:\Users\dabarbet\Downloads\officual_build_vsix\new_official_build\Microsoft.CodeAnalysis.LanguageServer.Protocol.dll
Reading IBC resource from file: C:\Users\dabarbet\Downloads\officual_build_vsix\new_official_build\Microsoft.CodeAnalysis.LanguageServer.Protocol.dll
Xml output file: C:\Users\dabarbet\Downloads\officual_build_vsix\new_official_build\Microsoft.CodeAnalysis.LanguageServer.Protocol.ibc.xml

image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 15, 2025
@dibarbet dibarbet marked this pull request as ready for review January 23, 2025 18:38
@dibarbet dibarbet requested a review from a team as a code owner January 23, 2025 18:38
@dibarbet dibarbet merged commit a8a7c6d into dotnet:main Jan 23, 2025
25 checks passed
@dibarbet dibarbet deleted the ngen_protocol branch January 23, 2025 18:46
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 23, 2025
@dotnet-bot dotnet-bot mentioned this pull request Jan 24, 2025
Closed
@dibarbet dibarbet modified the milestones: Next, 17.14 P1 Jan 28, 2025
This was referenced Jan 29, 2025
Closed
Closed
Closed
@333fred 333fred mentioned this pull request Feb 11, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu genlu genlu approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.14 P1
Development

Successfully merging this pull request may close these issues.
2 participants
@dibarbet @genlu