Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put WRN_InterceptsLocationAttributeUnsupportedSignature into .NET 9 warning wave #76642

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Put WRN_InterceptsLocationAttributeUnsupportedSignature into .NET 9 warning wave #76642

merged 2 commits into from
Jan 7, 2025

Conversation

RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson commented Jan 6, 2025 •
edited
Loading

Follow up to #76312
Closes #76641

#76641 (comment)

It was not our goal to make generator authors service the .NET 8 versions of their generators to start using InterceptableLocation. The goal was just to get people moved to the new way for .NET 9 and up. Our plan is to leave in support for the "old way" in the SDK, for as long as .NET 8 is supported. At the time .NET 8 goes out of support, we will fully remove the support for the "old way" from the newest SDK.

I think the resolution here should be to adjust the compiler so that warning InterceptsLocationAttribute(string, int, int) is not supported is only reported when targeting .NET 9 or later.

@RikkiGibson RikkiGibson requested a review from a team as a code owner January 6, 2025 20:03
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 6, 2025
@RikkiGibson
Copy link
Contributor Author

@cston @dotnet/roslyn-compiler for review of a small fix

AlekseyTs
AlekseyTs approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@RikkiGibson RikkiGibson merged commit 84d42b9 into dotnet:main Jan 7, 2025
24 checks passed
@RikkiGibson RikkiGibson deleted the ic-warning-wave branch January 7, 2025 00:00
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 7, 2025
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
@dotnet-bot dotnet-bot mentioned this pull request Jan 9, 2025
Closed
This was referenced Jan 10, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers Feature - Interceptors untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P3
5 participants
@RikkiGibson @jaredpar @AlekseyTs @dibarbet @jcouv