Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Default VB Version to 17.13 #76452

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Move Default VB Version to 17.13 #76452

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecb449b
Move Default VB Version to 17.13
AlekseyTs Dec 16, 2024
48abd30
Follow up
AlekseyTs Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compilers/VisualBasic/Portable/LanguageVersion.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
Case LanguageVersion.Latest
Return LanguageVersion.VisualBasic17_13
Case LanguageVersion.Default
Return LanguageVersion.VisualBasic16_9
Return LanguageVersion.VisualBasic17_13
Case Else
Return version
End Select
Expand Down
1 change: 1 addition & 0 deletions src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,6 +2104,7 @@ End Module").Path
Assert.Equal(LanguageVersion.VisualBasic16, LanguageVersion.VisualBasic16.MapSpecifiedToEffectiveVersion())
Assert.Equal(LanguageVersion.VisualBasic16_9, LanguageVersion.VisualBasic16_9.MapSpecifiedToEffectiveVersion())
Assert.Equal(LanguageVersion.VisualBasic17_13, LanguageVersion.VisualBasic17_13.MapSpecifiedToEffectiveVersion())
Assert.Equal(LanguageVersion.VisualBasic17_13, LanguageVersion.Default.MapSpecifiedToEffectiveVersion())
Copy link
Member

@jcouv jcouv Dec 16, 2024 •
edited by AlekseyTs
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the comment below points to some instructions for adding a new VB language version.
But the first bullet is not applicable (no UpgradeProject for VB) and the last bullet is no longer applicable (that document doesn't include specific version numbers since we added /LangVersion:?). Would you mind removing them?
 

  ' When a new version is added, this test will break. This list must be checked:
  ' - update the "UpgradeProject" codefixer (not yet supported in VB)
  ' - update all the tests that call this canary
  ' - update the command-line documentation (CommandLine.md)
``` #Resolved


' The canary check is a reminder that this test needs to be updated when a language version is added
LanguageVersionAdded_Canary()
Expand Down
Loading