Reduce allocations in AbstractSymbolCompletionProvider.UnionSymbols #76368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method show up as about 2.3% of allocations in the typing scenario of the csharp editing speedometer test. Of that, about 1.8% appears to be addressable by not creating an anonymous type and rolling out the linq groupby into a pooled hashset.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
JoeRobich
approved these changes
Dec 11, 2024
CyrusNajmabadi
approved these changes
Dec 11, 2024
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method show up as about 2.3% of allocations in the typing scenario of the csharp editing speedometer test. Of that, about 1.8% appears to be addressable by not creating an anonymous type and rolling out the linq groupby into a pooled hashset.