Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor synchronize loader #76357

Merged
merged 9 commits into from
Dec 12, 2024
Prev Previous commit
Next Next commit
PR Feedback
  • Loading branch information
chsienki committed Dec 12, 2024
commit 481921f48e214bc86ee355dbfe4b08fa16fcd0cb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ internal class RazorAnalyzerAssemblyResolver() : IAnalyzerAssemblyResolver
{
private static Func<AssemblyName, Assembly?>? s_assemblyResolver;

private static readonly List<AssemblyName> s_assembliesRequested = [];
private static readonly HashSet<AssemblyName> s_assembliesRequested = [];

private static readonly object s_resolverLock = new();

Expand Down
1 change: 0 additions & 1 deletion src/Tools/ExternalAccess/Razor/RazorProjectExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ internal static async ValueTask<IEnumerable<SourceGeneratedDocument>> GetSourceG

var generatorIdentity = new SourceGeneratorIdentity(assemblyName, assemblyPath, assemblyVersion, typeName);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SourceGeneratorIdentity isn't public, so have to pass through the requisite parts. We could make an IVT copy but doesn't seem worth it.

return results.Where(s => s.Identity.Generator == generatorIdentity);

}
}
}