Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have go-to-def flip between partial definition and implementation #76187

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Have go-to-def flip between partial definition and implementation #76187

merged 2 commits into from
Dec 3, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #76156

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 30, 2024 22:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 30, 2024
ToddGrun
ToddGrun reviewed Dec 3, 2024
View reviewed changes
src/EditorFeatures/Core/Navigation/AbstractDefinitionLocationService.cs
@@ -251,6 +249,24 @@ async ValueTask<ImmutableArray<DefinitionItem>> GetInterceptorDefinitionsAsync(
});
}
}
async ValueTask<INavigableLocation?> TryGetOtherPartOfPartialAsync()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async ValueTask<INavigableLocation?> TryGetOtherPartOfPartialAsync()

nit: missing newline

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in followup.

ToddGrun
ToddGrun approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 6c2553e into dotnet:main Dec 3, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the gotoDefPartial branch December 3, 2024 01:17
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 3, 2024
@dotnet-bot dotnet-bot mentioned this pull request Dec 4, 2024
Closed
@Shujee
Copy link

Shujee commented Dec 10, 2024

Just trying to understand the status. Does this fix the problem where F12-ing a generated ObservableProperty takes us to .g.cs file instead of actual underlying local field? If so, has this been pushed to the main updates channel? When can we expect it to appear in GA version of VS2022?

@CyrusNajmabadi
Copy link
Member Author

Just trying to understand the status. Does this fix the problem where F12-ing a generated ObservableProperty takes us to .g.cs file instead of actual underlying local field?

F12 on a partial will take you to one of the parts of the partial. F12 on that partial will take you to the other part (and vice versa). So you can trivially navigate to whichever you prefer.

If so, has this been pushed to the main updates channel? When can we expect it to appear in GA version of VS2022

A bot adds that information when this merges into the main vs tree.

This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@akhera99 akhera99 Awaiting requested review from akhera99

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

CTRL + click (and F12) on a partial property should always jump to user-defined part
4 participants
@CyrusNajmabadi @Shujee @ToddGrun @dibarbet