Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support implementing protected members in implement interface #76178

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Support implementing protected members in implement interface #76178

merged 3 commits into from
Dec 3, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Nov 30, 2024 •
edited
Loading

Fixes #72380

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 30, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review November 30, 2024 07:58
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 30, 2024 07:58
ToddGrun
ToddGrun approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 45483ea into dotnet:main Dec 3, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the implementInterfaceProtected branch December 3, 2024 18:02
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 3, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

Implement interfaces code fix does not implement protected interface members non-explicitly
3 participants
@CyrusNajmabadi @ToddGrun @dibarbet