Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show uncapturable outer parameters inside static local functions. #76043

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Do not show uncapturable outer parameters inside static local functions. #76043

merged 6 commits into from
Nov 25, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #66982

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 22, 2024 22:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 22, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 23, 2024
Open
3 tasks
ToddGrun
ToddGrun reviewed Nov 25, 2024
View reviewed changes
src/Workspaces/CSharp/Portable/Recommendations/CSharpRecommendationServiceRunner.cs Outdated
? _context.SemanticModel.LookupStaticMembers(_context.LeftToken.SpanStart)
: _context.SemanticModel.LookupSymbols(_context.LeftToken.SpanStart);
ImmutableArray<ISymbol> symbols;
if (_context.IsNameOfContext)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (_context.IsNameOfContext)

meant to be in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is a followup to another pr (waiting on you to review as well) :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. rereview.

@CyrusNajmabadi CyrusNajmabadi requested review from genlu and a team November 25, 2024 21:54
ToddGrun
ToddGrun approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 40881ef into dotnet:main Nov 25, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 25, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the completionParameters branch November 25, 2024 23:25
@dotnet-bot dotnet-bot mentioned this pull request Nov 29, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@genlu genlu Awaiting requested review from genlu

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

Completions suggest unreachable variables in static local functions
3 participants
@CyrusNajmabadi @ToddGrun @dibarbet