Change inline diagnostics tagger to be a viewport tagger #75836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
akhera99
approved these changes
Nov 8, 2024
ToddGrun
reviewed
Nov 8, 2024
| @@ -111,7 +95,7 @@ protected override async Task ProduceTagsAsync( | |||
|
|
|||
| var options = GlobalOptions.GetInlineHintsOptions(document.Project.Language); | |||
|
|
|||
| var snapshotSpan = documentSnapshotSpan.SnapshotSpan; | |||
| var snapshotSpan = spanToTag.SnapshotSpan; | |||
There was a problem hiding this comment.
Couple nits not related to this PR, I'm not sure how often this code is invoked:
-
Should the code in the loop be using Text instead of ToString()? I know the impl delegates ToString() to Text, but it seems weird to rely on that.
-
The Sum could instead by an All with length 0. No need to walk all the display parts.
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already replicating hte logic to tag parts of the file out of view. This just sits us on the existing mechanism for doing that.