Redirect SDK analyzers to VS #74775
Closed
Redirect SDK analyzers to VS #74775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
jjonescz
commented
Aug 15, 2024
| /// Analyzers loaded from SDK are redirected to these VS-inserted analyzers | ||
| /// by <see cref="RedirectingAnalyzerAssemblyResolver"/>. | ||
| /// </summary> | ||
| internal sealed class InsertedAnalyzerProvider |
There was a problem hiding this comment.
This is for the most part a copy of VisualStudioDiagnosticAnalyzerProvider which does something similar - discovers analyzers from VSIXes.
| @@ -77,6 +80,8 @@ public async Task<ProjectSystemProject> CreateAndAddToWorkspaceAsync( | |||
|
|
|||
| var vsixAnalyzerProvider = await _vsixAnalyzerProviderFactory.GetOrCreateProviderAsync(cancellationToken).ConfigureAwait(false); | |||
|
|
|||
| _visualStudioWorkspaceImpl.LazyInsertedAnalyzerProvider = await _insertedAnalyzerProviderFactory.GetOrCreateProviderAsync(cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
I wasn't sure where to put this "discovery of VSIX analyzers" (I'm not very familiar with the IDE part of the codebase) - I need that to be done before the RedirectingAnalyzerAssemblyResolver is called. I chose this place because it's where the similar IVisualStudioDiagnosticAnalyzerProviderFactory is called.
| return null; | ||
| } | ||
|
|
||
| private ImmutableArray<Matcher> CreateMatchers() |
There was a problem hiding this comment.
This could be improved (e.g., by creating regexes), but I'm not sure the spec is final yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://github.com/jjonescz/dotnet-sdk/blob/tearing-redirect/documentation/general/analyzer-redirecting.md
Part of dotnet/sdk#42087.