Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Codelens provider to .NET #74321

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Migrate Codelens provider to .NET #74321

merged 10 commits into from
Oct 24, 2024

Conversation

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 9, 2024
@genlu genlu requested a review from allisonchou August 12, 2024 23:56
@genlu genlu marked this pull request as ready for review August 16, 2024 21:55
@genlu genlu requested a review from a team as a code owner August 16, 2024 21:55
@genlu genlu changed the title [WIP] Migrate Codelens provider to .NET Migrate Codelens provider to .NET Aug 16, 2024
@genlu genlu marked this pull request as draft August 16, 2024 21:55
@genlu
Copy link
Member Author

genlu commented Aug 16, 2024

@dotnet/roslyn-ide This is now ready for review. @allisonchou has confirmed the change works with the .NET codelens host from editor. I'm keeping this PR as draft because it's blocked until the change on editor side landed in VS.

@CyrusNajmabadi
Copy link
Member

@dotnet/roslyn-ide This is now ready for review

want to take out of draft?

@genlu
Copy link
Member Author

genlu commented Aug 16, 2024

@CyrusNajmabadi Keeping it a draft so we don't accidentally merge it before editor insert their change

@CyrusNajmabadi
Copy link
Member

Ah ok!

@genlu genlu marked this pull request as ready for review October 17, 2024 21:33
@genlu genlu merged commit cd336d2 into dotnet:main Oct 24, 2024
25 checks passed
@genlu genlu deleted the codelens branch October 24, 2024 22:41
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 24, 2024
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants