Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse
field
as a contextual keyword #73947Parse
field
as a contextual keyword #73947Changes from 37 commits
9afc7e1
62bdd75
538db7e
55da141
96b23b5
dee9526
4d227d3
0ede824
5f40ed7
afcbacb
4919f39
b300536
7924bbe
05c024d
0ea409b
b957b4c
6f61596
0461361
94d3381
6626a89
412382a
2de28ec
ef1b6fa
fd03d65
4a01d5a
f0d6151
117fe3b
6cfd56a
50c45b2
33543b1
1c55beb
f165c4f
2b068b2
7ed1c3d
219d868
b4717dc
74f6f88
247c82c
1858006
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reported in
LanguageParser.ParseTermWithoutPostfix
rather than here. #ResolvedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an open issue that we are tracking resolving in a future PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was assuming the comment is the tracking. (It might be useful to move the diagnostic to the parser, but it doesn't seem necessary, so I didn't think it required an issue.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to not have an issue, but in that case I would expect a prototype comment, is there one present here that I missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we refine the diagnostic reporting to only report when
field
would not bind to a distinct symbol, reporting will need to stay in theBinder
. Given that, I'll leave the code as is, with no PROTOTYPE comment for now.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.