Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nullable-disabled semantic model for obsoletion classification analysis #73521

Merged
merged 1 commit into from
May 16, 2024
Merged

Use nullable-disabled semantic model for obsoletion classification analysis #73521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Workspaces/Core/Portable/ObsoleteSymbol/AbstractObsoleteSymbolService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ public async Task<ImmutableArray<TextSpan>> GetLocationsAsync(Document document,
{
var syntaxFacts = document.GetRequiredLanguageService<ISyntaxFactsService>();

var semanticModel = await document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false);
// Obsolete analysis doesn't need nullable information. This saves substantial time computing obsoletion information.
var semanticModel = await document.GetRequiredNullableDisabledSemanticModelAsync(cancellationToken).ConfigureAwait(false);
var root = await document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false);

// Avoid taking a builder from the pool in the common case where there are no references to obsolete symbols
Expand Down
Loading