Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize 'allows ref struct' constraint in VB compiler #73429

Merged
merged 2 commits into from
May 14, 2024
Merged

Recognize 'allows ref struct' constraint in VB compiler #73429

merged 2 commits into from
May 14, 2024

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested review from jjonescz and cston May 10, 2024 19:40
@AlekseyTs AlekseyTs requested a review from a team as a code owner May 10, 2024 19:40
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label May 10, 2024
@AlekseyTs
Copy link
Contributor Author

@cston, @jjonescz, @dotnet/roslyn-compiler Please review

cston
cston reviewed May 14, 2024
View reviewed changes
src/Compilers/VisualBasic/Test/Symbol/SymbolsTests/RefStructInterfacesTests.vb
Dim comp1 = CreateCompilation(source1, targetFramework:=s_targetFrameworkSupportingByRefLikeGenerics, references:={csCompilation})

Dim m = comp1.GetMember(Of MethodSymbol)("B.M")
Assert.False(m.TypeParameters.Single().AllowsByRefLike)
Copy link
Member

@cston cston May 14, 2024 •
edited by AlekseyTs
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert.False(m.TypeParameters.Single().AllowsByRefLike)

Consider checking m.OverriddenMethod.TypeParameters.Single().AllowsByRefLike. #Resolved

cston
cston reviewed May 14, 2024
View reviewed changes
src/Compilers/VisualBasic/Test/Symbol/SymbolsTests/RefStructInterfacesTests.vb
</expected>)

Dim m = comp1.GetMember(Of MethodSymbol)("B.M")
Assert.False(m.TypeParameters.Single().AllowsByRefLike)
Copy link
Member

@cston cston May 14, 2024 •
edited by AlekseyTs
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert.False(m.TypeParameters.Single().AllowsByRefLike)

Consider checking m.ExplicitInterfaceImplementations.Single().TypeParameters.Single().AllowsByRefLike. #Resolved

@AlekseyTs
Copy link
Contributor Author

@jjonescz, @dotnet/roslyn-compiler For the second review

@AlekseyTs AlekseyTs merged commit 844663d into dotnet:features/RefStructInterfaces May 14, 2024
28 checks passed
This was referenced May 21, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjonescz jjonescz jjonescz approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers Feature - RefStructInterfaces untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekseyTs @jjonescz @cston