Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove primary ctor when moving a type. #72695

Merged
merged 8 commits into from
Mar 24, 2024
Merged

Remove primary ctor when moving a type. #72695

merged 8 commits into from
Mar 24, 2024

Conversation

juan-carlos-diaz
Copy link
Contributor

Fix #72632

@juan-carlos-diaz juan-carlos-diaz requested a review from a team as a code owner March 23, 2024 16:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 23, 2024
@CyrusNajmabadi
Copy link
Member

Done with pass.

@CyrusNajmabadi
Copy link
Member

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit 2fa323c into dotnet:main Mar 24, 2024
25 of 27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 24, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 26, 2024
Closed
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Nov 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.

Move type code fix results in compile error with primary constructors
4 participants
@juan-carlos-diaz @CyrusNajmabadi @RikkiGibson @juan-diaz-at-nicklaus