Remove notification on diagnostic updates in inline-diagnostics #72562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 15, 2024
| @@ -38,14 +39,12 @@ private sealed class SingleDiagnosticKindPullTaggerProvider( | |||
| AbstractDiagnosticsTaggerProvider<TTag> callback, | |||
| DiagnosticKind diagnosticKind, | |||
| IThreadingContext threadingContext, | |||
| IDiagnosticService diagnosticService, | |||
| IDiagnosticAnalyzerService analyzerService, | |||
There was a problem hiding this comment.
note, the IDiagnosticAnalyzerService is where we actually get the diagnostics from. the IDiagnosticService is the legacy service that serves to push out notifications that diagnostics cahnged to registered listeners. We're removing hte latter.
akhera99
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old vestige of talking to the push-diagnostics system. We don't need this anymore as inline-diags can just listen for workspace-changes, and then just update itself a short delay after that happens (like how all other taggers work).