Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant feature #72525

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Remove redundant feature #72525

merged 1 commit into from
Mar 13, 2024

Conversation

slang25
Copy link
Contributor

@slang25 slang25 commented Mar 13, 2024

This appears to be redundant now that params collection has been merged.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 13, 2024
jcouv
jcouv approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv
Copy link
Member

jcouv commented Mar 13, 2024

Thanks @slang25
FYI @cston @AlekseyTs. I closed the old associated test plan too.

@jcouv jcouv self-assigned this Mar 13, 2024
@jcouv jcouv merged commit 72396c0 into dotnet:main Mar 13, 2024
5 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 13, 2024
@slang25 slang25 deleted the patch-2 branch March 13, 2024 18:49
@dotnet-bot dotnet-bot mentioned this pull request Mar 21, 2024
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Documentation untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@slang25 @jcouv @RikkiGibson