Onboard VB intellisense page to Unified Settings #72471
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Cosifne
force-pushed
the
dev/shech/UnifiedSettings4
branch
from
2516c49 to
b12cc1c
Compare
Cosifne
force-pushed
the
dev/shech/UnifiedSettings4
branch
from
b12cc1c to
c3ef061
Compare
Cosifne
force-pushed
the
dev/shech/UnifiedSettings4
branch
from
0f52a71 to
6b32646
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
| @@ -214,4 +214,22 @@ Use enhanced colors;Editor Color Scheme;Inheritance Margin;Import Directives;</v | |||
| <data name="An_empty_Visual_Basic_script_file" xml:space="preserve"> | |||
| <value>An empty Visual Basic script file.</value> | |||
| </data> | |||
| <data name="Always_add_new_line_on_enter" xml:space="preserve"> | |||
There was a problem hiding this comment.
Need this because unified settings's enum label can only read from package resources now
There was a problem hiding this comment.
Can we remove the corresponding strings from their original location, and reference these from the legacy settings page instead?
There was a problem hiding this comment.
Possible, let me check the LOC time line
There was a problem hiding this comment.
Not all of them, some strings in our exsiting page have _ prefix, like:
for accessiblity purpose
But the _ will be displayed in unified settings page
| Dim snippetValue = Me.OptionStore.GetOption(CompletionOptionsStorage.EnterKeyBehavior, LanguageNames.VisualBasic) | ||
| If snippetValue = SnippetsRule.Default Then | ||
| Dim enterKeyRule = Me.OptionStore.GetOption(CompletionOptionsStorage.EnterKeyBehavior, LanguageNames.VisualBasic) | ||
| If enterKeyRule = EnterKeyRule.Default Then |
There was a problem hiding this comment.
so in the previous code
snippetValue is EnterKeyRule but compared to a SnippetsRule.Default
Here change it to the correct type EnterKeyRule
(Complier think it's OK, emm? )
But since they all default to value 0, so no functional change in fact.
|
Tag @sharwell to revisit this, I remember we used to think there is no test coverage for the json registration file. |
We have already done this for C# #71780
This is based on #72429 because we use the new attribute to specify the registration.json file