Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NewtonsoftJsonVersion problem #71876

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Jan 30, 2024

CG alert:https://dev.azure.com/dnceng/internal/_build/results?buildId=2365365&view=logs&j=20fcf628-b65c-5865-625a-1cef81cda63b&t=4d8b3807-d846-5582-4571-f8819aaf8b3b

The assumption is https://github.com/dotnet/roslyn/blob/main/eng/InternalTools.props has a dependency to Newtonsoft.Json, since the version number is removed when everything changed to NuGet Central package management, it falls to the oldest version.

@Cosifne Cosifne requested a review from a team as a code owner January 30, 2024 20:23
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 30, 2024
@Cosifne Cosifne enabled auto-merge February 1, 2024 18:46
@Cosifne Cosifne merged commit e7cae31 into dotnet:main Feb 1, 2024
28 of 31 checks passed
@ghost ghost added this to the Next milestone Feb 1, 2024
@jjonescz jjonescz modified the milestones: Next, 17.10 P2 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants