Ensure both parts of partial methods are analyzed when requesting analyzer diagnostics for a single file #71201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified that the test fails for `separateFiles = true` and passes for `separateFiles = false`, confirming that SymbolEnd action is not being called when the type has a partial definition in a separate file with partial member implementation part.
…analysis, regardless of whether one or both of them are defined in the same file Fixes dotnet#71149
dotnet-issue-labeler
bot
added
the
untriaged
CyrusNajmabadi
approved these changes
Dec 11, 2023
|
@333fred could you ptal. thanks! |
Yes, this should fix that issue. I tried adding the unit test for the analyzer first and get it to fail. However, the MS.CA.Testing library runs the test by computing diagnostics over the whole compilation, it does not mimic IDE open file analysis that requests diagnostics for a single file at a time. This bug only repros with the latter approach, hence adding an IDE analyzer test won’t help with respect to this fix. |
|
@mavasani Gotcha. |
333fred
approved these changes
Dec 11, 2023
|
Thanks! |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71149
This is a bug in the core analyzer driver that only happens when we have a partial implementation part of a partial method in a separate file (doesn't matter if it is a regular file or a generated file), and this partial type definition has no other members defined. First commit in this PR: 65ca155 shows the unit test that fails when
separateFiles = truewithout the fix.The fix is to ensure we analyze both parts of partial when requesting analyzer diagnostics for a single file (happens for open file analysis for IDE live analysis)