Safely create VirtualCharSequence from string in StackFrameParser #59283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
commented
Feb 4, 2022
| /// <returns></returns> | ||
| public static VirtualChar CreateNextInString(string text, int index, Func<int, int, TextSpan> createSpan, out int consumedCharacters) | ||
| { | ||
| if (Rune.TryCreate(text[index], out var rune)) |
There was a problem hiding this comment.
Ported from AbstractVirtualCharService.cs
src/Features/Core/Portable/EmbeddedLanguages/StackFrame/StackFrameLexer.cs
Outdated
Show resolved
Hide resolved
...tiesAndExtensions/Compiler/Core/EmbeddedLanguages/VirtualChars/AbstractVirtualCharService.cs
Outdated
Show resolved
Hide resolved
...edUtilitiesAndExtensions/Compiler/Core/EmbeddedLanguages/VirtualChars/VirtualCharSequence.cs
Show resolved
Hide resolved
...edUtilitiesAndExtensions/Compiler/Core/EmbeddedLanguages/VirtualChars/VirtualCharSequence.cs
Outdated
Show resolved
Hide resolved
...edUtilitiesAndExtensions/Compiler/Core/EmbeddedLanguages/VirtualChars/VirtualCharSequence.cs
Outdated
Show resolved
Hide resolved
…rameLexer.cs Co-authored-by: CyrusNajmabadi <[email protected]>
…ddedLanguages/VirtualChars/VirtualCharSequence.cs Co-authored-by: CyrusNajmabadi <[email protected]>
…com/ryzngard/roslyn into issues/59258_stack_parse_assert
Youssef1313
reviewed
Feb 7, 2022
src/EditorFeatures/Test/EmbeddedLanguages/StackFrame/StackFrameParserTests.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
JoeRobich
approved these changes
May 23, 2022
JoeRobich
reviewed
May 24, 2022
Comment on lines
180
to
181
|
|
||
| index += ConvertTextAtIndexToRune(tokenText, index, result, offset); |
There was a problem hiding this comment.
This seems to already be handled by the else clause that you added. By having it here this code is executing twice and some of the text is not covered by the earlier quote and brace checks.
Suggested change
| index += ConvertTextAtIndexToRune(tokenText, index, result, offset); |
There was a problem hiding this comment.
Not entirely sure I follow. If we move the characters by a certain amount the index will always need to be added to. CreateNextInString will consume some number of characters to produce a virtualChar. That's separate from ConvertTextAtIndexToRune
…com/ryzngard/roslyn into issues/59258_stack_parse_assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59258