Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show colon suffix in property pattern completion #59031

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Don't show colon suffix in property pattern completion #59031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd09c20
Don't show colon suffix in property pattern completion
Youssef1313 Jan 23, 2022
3c6b2d6
Update PropertySubPatternCompletionProviderTests.cs
Youssef1313 Jan 23, 2022
54dad8c
Update CSharpCompletionCommandHandlerTests.vb
Youssef1313 Jan 23, 2022
0172bc1
Update CSharpCompletionCommandHandlerTests.vb
Youssef1313 Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 34 additions & 34 deletions ...es/CSharpTest/Completion/CompletionProviders/PropertySubPatternCompletionProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ void M()
}
";
// VerifyItemExistsAsync also tests with the item typed.
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand All @@ -57,8 +57,8 @@ void M()
public void Deconstruct(out int x, out int y) => throw null;
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand All @@ -78,8 +78,8 @@ void M()
public void Deconstruct(out int x, out int y) => throw null;
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand All @@ -98,8 +98,8 @@ void M()
}
}
";
await VerifyItemExistsAsync(markup, "@new", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "@struct", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "@new", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "@struct", displayTextSuffix: "");
}

[Fact]
Expand Down Expand Up @@ -138,8 +138,8 @@ class Derived
public int P2 { get; set; }
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand All @@ -160,8 +160,8 @@ class Other
public int F2;
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "F2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "F2", displayTextSuffix: "");
}

[Fact]
Expand Down Expand Up @@ -203,7 +203,7 @@ class Derived : Program
private int P2 { get; set; }
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
}

[Fact]
Expand All @@ -223,8 +223,8 @@ void M()
}
";
// VerifyItemExistsAsync also tests with the item typed.
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand All @@ -247,8 +247,8 @@ void M()
}
";
// VerifyItemExistsAsync also tests with the item typed.
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand All @@ -271,8 +271,8 @@ void M()
}
";
// VerifyItemExistsAsync also tests with the item typed.
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand All @@ -291,8 +291,8 @@ void M()
}
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand All @@ -318,8 +318,8 @@ void M()
";
await VerifyItemIsAbsentAsync(markup, "P1");
await VerifyItemIsAbsentAsync(markup, "P2");
await VerifyItemExistsAsync(markup, "P3", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P4", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P3", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P4", displayTextSuffix: "");
}

[Fact]
Expand All @@ -345,8 +345,8 @@ void M()
";
await VerifyItemIsAbsentAsync(markup, "P1");
await VerifyItemIsAbsentAsync(markup, "F2");
await VerifyItemExistsAsync(markup, "P3", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P4", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P3", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P4", displayTextSuffix: "");
}

[Fact]
Expand All @@ -372,8 +372,8 @@ void M()
";
await VerifyItemIsAbsentAsync(markup, "P1");
await VerifyItemIsAbsentAsync(markup, "P2");
await VerifyItemExistsAsync(markup, "F3", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "F4", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "F3", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "F4", displayTextSuffix: "");
}

[Fact]
Expand Down Expand Up @@ -455,7 +455,7 @@ void M()
}
";
// VerifyItemExistsAsync also tests with the item typed.
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemIsAbsentAsync(markup, "P2");
}

Expand Down Expand Up @@ -542,7 +542,7 @@ void M()
public void Deconstruct(out Program x, out Program y) => throw null;
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
}

[Fact]
Expand All @@ -562,7 +562,7 @@ void M()
public void Deconstruct(out Program x, out Program y) => throw null;
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
}

[Fact]
Expand Down Expand Up @@ -604,7 +604,7 @@ void M()
public void Deconstruct(out Program x, out Program y) => throw null;
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
}

[Fact]
Expand All @@ -624,7 +624,7 @@ void M()
public void Deconstruct(out Program x, out Program y) => throw null;
}
";
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
}

[Fact]
Expand Down Expand Up @@ -665,8 +665,8 @@ void M()
}
";
// Ignore browsability limiting attributes if the symbol is declared in source.
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: ":");
await VerifyItemExistsAsync(markup, "P1", displayTextSuffix: "");
await VerifyItemExistsAsync(markup, "P2", displayTextSuffix: "");
}

[Fact]
Expand Down
Loading