Use interpolated string handler for Contract.ThrowIf methods #58173
+163
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Community
333fred
reviewed
Dec 7, 2021
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs
Show resolved
Hide resolved
333fred
reviewed
Dec 7, 2021
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Dec 7, 2021
|
|
||
| public void AppendLiteral(string value) => _stringBuilder?.Append(value); | ||
|
|
||
| public void AppendFormatted<T2>(T2 value) => _stringBuilder?.Append(value?.ToString()); |
There was a problem hiding this comment.
Couldn't find good names for the type parameters.
333fred
reviewed
Dec 7, 2021
src/Compilers/Core/Portable/InternalUtilities/InterpolatedStringHandlerArgumentAttribute.cs
Show resolved
Hide resolved
Youssef1313
force-pushed
the
heavy-allocations
branch
2 times, most recently
from
fe7a3a7 to
78b91d8
Compare
Youssef1313
force-pushed
the
heavy-allocations
branch
from
78b91d8 to
c8630e5
Compare
333fred
approved these changes
Dec 8, 2021
|
@333fred Anything left here? |
|
@sharwell @dotnet/roslyn-ide for review. |
|
@sharwell for review. |
|
@sharwell Can you review please? Thanks! |
sharwell
reviewed
Jan 19, 2022
.../SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.InterpolatedStringHandlers.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jan 19, 2022
.../SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.InterpolatedStringHandlers.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jan 19, 2022
.../SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.InterpolatedStringHandlers.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Jan 19, 2022
…ities/Contract.InterpolatedStringHandlers.cs Co-authored-by: Sam Harwell <[email protected]>
…ities/Contract.InterpolatedStringHandlers.cs Co-authored-by: Sam Harwell <[email protected]>
…ities/Contract.InterpolatedStringHandlers.cs Co-authored-by: Sam Harwell <[email protected]>
sharwell
approved these changes
Jan 19, 2022
333fred
reviewed
Jan 20, 2022
jaredpar
reviewed
Jan 20, 2022
.../SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.InterpolatedStringHandlers.cs
Outdated
Show resolved
Hide resolved
.../SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.InterpolatedStringHandlers.cs
Outdated
Show resolved
Hide resolved
.../SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.InterpolatedStringHandlers.cs
Outdated
Show resolved
Hide resolved
.../SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.InterpolatedStringHandlers.cs
Outdated
Show resolved
Hide resolved
|
@jaredpar any more feedback? |
|
@jaredpar Can you take a look please? Thanks! |
jaredpar
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58165
cc @333fred @sharwell @CyrusNajmabadi
I'm not sure if I'm doing it right